You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opening this PR for discussion. I'm not sure about the approach, or if there are additional requirements to get a change like this accepted.
The raw additions seem heavy compared to its other methods, but I tried to take a similar stance of handling all memory management there. Since the sqlite flags for these functions are related to memory management, they are not exposed in the raw api. The support for Stream is a simple, standard way to avoid a buffer, but it is a new reference to System.IO.
From an initial read, this is nice work. Thanks for submitting it. I may still have feedback or requested changes when I go through it more closely, which I hope to get done soon.
In principle, I have to push back on the use of System.IO.Stream. Anything that high-level is usually omitted from this library, with the expectation that upper layers will provide it.
I'm staring at the deserialize call that accepts a ReadOnlySpan and then allocates a block and copies it. That just feels wrong. I haven't actually used the sqlite3_deserialize() API, so I've been reading the docs, and I sort of see why you did things this way. But it raises questions as I look at the code.
Once we get the code looking okay for merge, I'll be asking for this PR to include test cases.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this PR for discussion. I'm not sure about the approach, or if there are additional requirements to get a change like this accepted.
The
rawadditions seem heavy compared to its other methods, but I tried to take a similar stance of handling all memory management there. Since the sqlite flags for these functions are related to memory management, they are not exposed in the raw api. The support for Stream is a simple, standard way to avoid a buffer, but it is a new reference to System.IO.